Skip to content

[TOOL-3453] Dashboard: Fix NFT Metadata issues when adding media URLs instead of uploading #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

[TOOL-3453] Dashboard: Fix NFT Metadata issues when adding media URLs instead of uploading #6288

merged 1 commit into from
Feb 18, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 18, 2025 •
edited by pr-codex bot
Loading

=

PR-Codex overview

This PR focuses on updating the NFT metadata handling in the dashboard application, including changes to form fields and validation, and improving the user interface for updating NFT metadata.

Detailed summary

  • Updated URLs in comments for TypeScript configuration.
  • Changed customImage and customAnimationUrl to image and animation_url in multiple components.
  • Updated titles and labels in UI components to reflect changes in functionality.
  • Enhanced form validation and error handling for image and animation URLs.
  • Improved layout and styling in various components, including adding gaps and adjusting classes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 6:35pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 18, 2025 6:35pm
login ⬜️ Skipped (Inspect) Feb 18, 2025 6:35pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 18, 2025 6:35pm
wallet-ui ⬜️ Skipped (Inspect) Feb 18, 2025 6:35pm

@linear
Copy link

linear bot commented Feb 18, 2025

TOOL-3453 Dashboard: Update Metadata is adding extra fields.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 18, 2025 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 18, 2025 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 18, 2025 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 18, 2025 18:18 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5d504e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 18, 2025
@MananTank MananTank marked this pull request as ready for review February 18, 2025 18:18
@MananTank MananTank requested review from a team as code owners February 18, 2025 18:18
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.84%. Comparing base (5abbae7) to head (ee95192).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6288   +/-   ##
=======================================
  Coverage   56.84%   56.84%           
=======================================
  Files        1168     1168           
  Lines       64789    64789           
  Branches     5259     5259           
=======================================
  Hits        36828    36828           
  Misses      27233    27233           
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5abbae7
packages 55.05% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 312 ms (+49.49% 🔺) 1.3 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 685 ms (+24.53% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 94 ms (+267.11% 🔺) 206 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 35 ms (+122.53% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 77 ms (+13.47% 🔺) 463 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 18, 2025 •
edited
Loading

Merge activity

graphite-app bot pushed a commit that referenced this pull request Feb 18, 2025
@MananTank
[TOOL-3453] Dashboard: Fix NFT Metadata issues when adding media URLs…
5d504e2 
… instead of uploading (#6288)

=
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 18, 2025 18:26 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 18, 2025 18:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 18, 2025 18:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 18, 2025 18:26 Inactive
@MananTank
[TOOL-3453] Dashboard: Fix NFT Metadata issues when adding media URLs…
ee95192 
… instead of uploading (#6288)

=

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the NFT metadata handling in the dashboard application, specifically renaming and refactoring properties related to custom images and animations, improving form handling, and enhancing user interface elements.

### Detailed summary
- Updated documentation link in `next-env.d.ts`.
- Changed `customImage` and `customAnimationUrl` to `image` and `animation_url` in multiple components.
- Updated titles and headers for improved clarity in forms.
- Enhanced form controls with better error handling and user feedback.
- Adjusted layout and spacing in several components for better usability.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 18, 2025 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 18, 2025 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 18, 2025 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 18, 2025 18:31 Inactive
@graphite-app graphite-app bot merged commit ee95192 into main Feb 18, 2025
32 of 33 checks passed
@graphite-app graphite-app bot deleted the TOOOL-3453 branch February 18, 2025 18:36
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 18, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 18, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 18, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Production – login February 18, 2025 18:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls